Soma summation report fix for SONATA simulations #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Both Cell/Soma SectionType should work
pramodk
approved these changes
Jan 5, 2024
|
|
✔️ e443f06 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2647 +/- ##
=======================================
Coverage 66.19% 66.19%
=======================================
Files 559 559
Lines 108956 108957 +1
=======================================
+ Hits 72126 72127 +1
Misses 36830 36830 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://bbpteam.epfl.ch/project/issues/browse/BBPBGLIB-1107
There were inconsistencies between BlueConfig and SONATA simulations when creating summation reports with Cell targets (BlueConfig) and "sections": "soma" (SONATA).
Both should give the same results, but the proper calculation was only being executed for Cell SectionType.